[MD] UX refactor for datasource create page #2501

yibow98 · 2022-10-04T20:37:13Z

Signed-off-by: Yibo Wang yibow@amazon.com

Description

UX refactor for datasource create page

Issues Resolved

opensearch-project/ux#19
opensearch-project/ux#23
opensearch-project/ux#24
opensearch-project/ux#25
opensearch-project/ux#26
opensearch-project/ux#29
#2434
#2439

Check List

zhongnansu

fix Build CI.
add change log
update snapshot tests?

src/plugins/data_source_management/public/types.ts

src/plugins/data_source_management/public/components/text_content/text_content.ts

noCharger · 2022-10-04T21:32:05Z

Do we need to update the snapshot as well?

...blic/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx

Signed-off-by: Yibo Wang <yibow@amazon.com>

codecov-commenter · 2022-10-07T00:19:48Z

Codecov Report

Merging #2501 (858ea59) into main (7777749) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2501   +/-   ##
=======================================
  Coverage   66.73%   66.73%           
=======================================
  Files        3203     3204    +1     
  Lines       60978    60988   +10     
  Branches     9274     9274           
=======================================
+ Hits        40692    40702   +10     
  Misses      18067    18067           
  Partials     2219     2219

Impacted Files	Coverage Δ
src/core/public/doc_links/doc_links_service.ts	`100.00% <ø> (ø)`
...components/create_form/create_data_source_form.tsx	`83.60% <100.00%> (+0.27%)`	⬆️
...te_data_source_wizard/components/header/header.tsx	`100.00% <100.00%> (ø)`
...ent/public/components/text_content/text_content.ts	`100.00% <100.00%> (ø)`
...nent/experimental_callout/experimental_callout.tsx	`100.00% <100.00%> (ø)`
...ared/static/forms/hook_form_lib/hooks/use_field.ts	`65.70% <0.00%> (-0.97%)`	⬇️
...ic/application/models/sense_editor/sense_editor.ts	`64.00% <0.00%> (-0.89%)`	⬇️
packages/osd-optimizer/src/node/cache.ts	`52.77% <0.00%> (+2.77%)`	⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts	`87.75% <0.00%> (+4.08%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Yibo Wang <yibow@amazon.com>

...nagement/public/management_app/compoenent/experimental_callout/experimental_callout.test.tsx

ashwin-pc

@yibow98 and I discussed offline and agreed that this and other unit tests will be addressed in a follow up PR. @yibow98 please link this PR to that so that it is easier to discover those changes in future.

yibow98 · 2022-10-11T00:49:17Z

@yibow98 and I discussed offline and agreed that this and other unit tests will be addressed in a follow up PR. @yibow98 please link this PR to that so that it is easier to discover those changes in future.

Thanks @ashwin-pc for giving me some constructive feedback and suggestions. Will address all unit test issues in my next PR and I will link this PR as a reference~

opensearch-trigger-bot · 2022-10-11T20:46:45Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2501-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9b56ff50327154cd531fcd4479ab2fc3798cf86b
# Push it to GitHub
git push --set-upstream origin backport/backport-2501-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2501-to-2.x.

* UX refactor for datasource create page Signed-off-by: Yibo Wang <yibow@amazon.com> * address comments&add CHANGLOG Signed-off-by: Yibo Wang <yibow@amazon.com> * Apply callout in all ds pages & update endpoint field placeholder text Signed-off-by: Yibo Wang <yibow@amazon.com> * add documentation links Signed-off-by: Yibo Wang <yibow@amazon.com> * update snapshot test and snapshots Signed-off-by: Yibo Wang <yibow@amazon.com> * Update CHANGELOG.md&.lycheeexclude Signed-off-by: Yibo Wang <yibow@amazon.com> * Update UT Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> (cherry picked from commit 9b56ff5)

* UX refactor for datasource create page Signed-off-by: Yibo Wang <yibow@amazon.com> * address comments&add CHANGLOG Signed-off-by: Yibo Wang <yibow@amazon.com> * Apply callout in all ds pages & update endpoint field placeholder text Signed-off-by: Yibo Wang <yibow@amazon.com> * add documentation links Signed-off-by: Yibo Wang <yibow@amazon.com> * update snapshot test and snapshots Signed-off-by: Yibo Wang <yibow@amazon.com> * Update CHANGELOG.md&.lycheeexclude Signed-off-by: Yibo Wang <yibow@amazon.com> * Update UT Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> (cherry picked from commit 9b56ff5) Co-authored-by: Yibo Wang <109543558+yibow98@users.noreply.github.com>

…opensearch-project#2559) * UX refactor for datasource create page Signed-off-by: Yibo Wang <yibow@amazon.com> * address comments&add CHANGLOG Signed-off-by: Yibo Wang <yibow@amazon.com> * Apply callout in all ds pages & update endpoint field placeholder text Signed-off-by: Yibo Wang <yibow@amazon.com> * add documentation links Signed-off-by: Yibo Wang <yibow@amazon.com> * update snapshot test and snapshots Signed-off-by: Yibo Wang <yibow@amazon.com> * Update CHANGELOG.md&.lycheeexclude Signed-off-by: Yibo Wang <yibow@amazon.com> * Update UT Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> (cherry picked from commit 9b56ff5) Co-authored-by: Yibo Wang <109543558+yibow98@users.noreply.github.com>

* UX refactor for datasource create page Signed-off-by: Yibo Wang <yibow@amazon.com> * address comments&add CHANGLOG Signed-off-by: Yibo Wang <yibow@amazon.com> * Apply callout in all ds pages & update endpoint field placeholder text Signed-off-by: Yibo Wang <yibow@amazon.com> * add documentation links Signed-off-by: Yibo Wang <yibow@amazon.com> * update snapshot test and snapshots Signed-off-by: Yibo Wang <yibow@amazon.com> * Update CHANGELOG.md&.lycheeexclude Signed-off-by: Yibo Wang <yibow@amazon.com> * Update UT Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>

yibow98 requested a review from a team as a code owner October 4, 2022 20:37

yibow98 self-assigned this Oct 4, 2022

yibow98 added multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 4, 2022

yibow98 assigned KrooshalUX Oct 4, 2022

yibow98 changed the title ~~UX refactor for datasource create page~~ [MD] UX refactor for datasource create page Oct 4, 2022

zhongnansu reviewed Oct 4, 2022

View reviewed changes

src/plugins/data_source_management/public/types.ts Outdated Show resolved Hide resolved

noCharger reviewed Oct 4, 2022

View reviewed changes

src/plugins/data_source_management/public/components/text_content/text_content.ts Outdated Show resolved Hide resolved

zhongnansu reviewed Oct 4, 2022

View reviewed changes

...blic/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx Outdated Show resolved Hide resolved

yibow98 force-pushed the new-ux-ds-creation branch 2 times, most recently from faeaa83 to 8dd3132 Compare October 4, 2022 23:10

zhongnansu added the backport 2.x label Oct 5, 2022

yibow98 marked this pull request as draft October 5, 2022 18:04

yibow98 force-pushed the new-ux-ds-creation branch 5 times, most recently from 96e3bb4 to c0a2537 Compare October 5, 2022 23:29

noCharger mentioned this pull request Oct 6, 2022

[MD] functional test for datasource creation page opensearch-project/opensearch-dashboards-functional-test#316

Merged

2 tasks

yibow98 added 4 commits October 6, 2022 13:38

UX refactor for datasource create page

3cd8481

Signed-off-by: Yibo Wang <yibow@amazon.com>

address comments&add CHANGLOG

d60adad

Signed-off-by: Yibo Wang <yibow@amazon.com>

Apply callout in all ds pages & update endpoint field placeholder text

a7a4aaa

Signed-off-by: Yibo Wang <yibow@amazon.com>

add documentation links

89d2b49

Signed-off-by: Yibo Wang <yibow@amazon.com>

yibow98 force-pushed the new-ux-ds-creation branch 2 times, most recently from b615245 to 89d2b49 Compare October 6, 2022 20:59

update snapshot test and snapshots

1ca6d1d

Signed-off-by: Yibo Wang <yibow@amazon.com>

yibow98 marked this pull request as ready for review October 6, 2022 23:33

yibow98 force-pushed the new-ux-ds-creation branch from ccf9e03 to 03002ed Compare October 10, 2022 18:38

Update UT

56d4bf8

Signed-off-by: Yibo Wang <yibow@amazon.com>

yibow98 force-pushed the new-ux-ds-creation branch from 03002ed to 56d4bf8 Compare October 10, 2022 18:40

kristenTian previously approved these changes Oct 10, 2022

View reviewed changes

mpabba3003 requested a review from ashwin-pc October 10, 2022 20:39

Merge branch 'main' into new-ux-ds-creation

b799626

ashwin-pc reviewed Oct 11, 2022

View reviewed changes

...nagement/public/management_app/compoenent/experimental_callout/experimental_callout.test.tsx Show resolved Hide resolved

ashwin-pc previously approved these changes Oct 11, 2022

View reviewed changes

Merge branch 'main' into new-ux-ds-creation

18eef6d

yibow98 dismissed stale reviews from ashwin-pc and kristenTian via 18eef6d October 11, 2022 00:50

ashwin-pc previously approved these changes Oct 11, 2022

View reviewed changes

Merge branch 'main' into new-ux-ds-creation

858ea59

yibow98 dismissed ashwin-pc’s stale review via 858ea59 October 11, 2022 04:06

abbyhu2000 approved these changes Oct 11, 2022

View reviewed changes

Merge branch 'main' into new-ux-ds-creation

ee7c0c0

kristenTian approved these changes Oct 11, 2022

View reviewed changes

kristenTian merged commit 9b56ff5 into opensearch-project:main Oct 11, 2022

zhongnansu added backport 2.x and removed backport 2.x labels Oct 12, 2022

opensearch-trigger-bot bot mentioned this pull request Oct 12, 2022

[Backport 2.x] [MD] UX refactor for datasource create page #2559

Merged

yibow98 mentioned this pull request Oct 13, 2022

[MD] Make text content dynamically translated & update unit tests #2570

Merged

8 tasks

AMoo-Miki added the enhancement New feature or request label Nov 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MD] UX refactor for datasource create page #2501

[MD] UX refactor for datasource create page #2501

yibow98 commented Oct 4, 2022 •

edited

Loading

zhongnansu left a comment

noCharger commented Oct 4, 2022

codecov-commenter commented Oct 7, 2022 •

edited

Loading

ashwin-pc left a comment

yibow98 commented Oct 11, 2022

opensearch-trigger-bot bot commented Oct 11, 2022

[MD] UX refactor for datasource create page #2501

[MD] UX refactor for datasource create page #2501

Conversation

yibow98 commented Oct 4, 2022 • edited Loading

Description

Issues Resolved

Check List

zhongnansu left a comment

Choose a reason for hiding this comment

noCharger commented Oct 4, 2022

codecov-commenter commented Oct 7, 2022 • edited Loading

Codecov Report

ashwin-pc left a comment

Choose a reason for hiding this comment

yibow98 commented Oct 11, 2022

opensearch-trigger-bot bot commented Oct 11, 2022

yibow98 commented Oct 4, 2022 •

edited

Loading

codecov-commenter commented Oct 7, 2022 •

edited

Loading